Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan out notification features #5

Open
mattjegan opened this issue Sep 8, 2017 · 2 comments
Open

Plan out notification features #5

mattjegan opened this issue Sep 8, 2017 · 2 comments
Milestone

Comments

@mattjegan
Copy link
Owner

No description provided.

@clintonb
Copy link

clintonb commented Sep 8, 2017

A mistake that some apps make is that they do too much. I want a badging library, not a badging and notifications library. Odds are my rules for notifications (e.g. timing, unsubscribed users) are different than yours. Same goes for my methods of notification (e.g. email, push).

Instead of sending an email/alert, fire a signal when a badge is awarded. Such a signal would probably be the same as Django's existing save signal, but there may be some value in providing a custom name (e.g. badge.awarded) for future expansion.

@mattjegan
Copy link
Owner Author

Thanks @clintonb for the input, definitely something to have a think about. I think the signal route very well might be the way to go with this 😄

@mattjegan mattjegan added this to the 0.4.0 milestone Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants