You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reading the IContractDeployer interface, it's not clear what the parameters of each function do especially for important functions such as the create and create2 functions.
Please add @param natspec annotations for what each of the parameters do.
🤔 Rationale
Deploying contracts is different on zkSync than on Ethereum. Because of that, when users dig deep into what's going on under the hood, it should be very clear what's going on. Right now, attempting to "peek under the hood" will be met with disappointment and more confusion.
What is input?
What is bytehash?
etc
The text was updated successfully, but these errors were encountered:
🌟 Feature Request
Reading the
IContractDeployer
interface, it's not clear what the parameters of each function do especially for important functions such as thecreate
andcreate2
functions.era-contracts/system-contracts/contracts/interfaces/IContractDeployer.sol
Line 68 in f3630fc
📝 Description
Please add
@param
natspec annotations for what each of the parameters do.🤔 Rationale
Deploying contracts is different on zkSync than on Ethereum. Because of that, when users dig deep into what's going on under the hood, it should be very clear what's going on. Right now, attempting to "peek under the hood" will be met with disappointment and more confusion.
input
?bytehash
?etc
The text was updated successfully, but these errors were encountered: