-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] MSC1453: Antivirus support #3811
Comments
yup, the proposal here will implement ICAP. Someone needs to port the https://github.com/matrix-org/matrix-content-scanner#api doc into an MSC to flesh this out. |
Note that if you implement the check when downloading a file:
but if you perform file check on upload:
|
I think it is the best approach of DLP and Antivirus software because Matrix stay clean in that case. Bad file don't event uploaded. |
Well a hostile user then would simply disable the upload checks |
I personally think the best system would be a combination of both. Scan media during upload, as well as scanning files before serving. Store a list of mxc's and/or hashes of passed/failed media to prevent constant rescanning. |
Or scan files on upload, and on retrieve when requested by the local homeserver from a remote (on the local homeserver). |
Can this also be used for scanning media for illegal/harmful/disturbing content? |
You'd need to use a technique like Neural Hash to create a database of content you want to block, but theoretically you could use this to implement the integration, afaict. |
Please make sure that this is documented that it must be always opt-in for E2EE attachments. It's important that this is up to explicit user choice, after they have considered their threat model. Thanks! |
This is a placeholder for a future MSC to document a proposal for the antivirus stuff we've been experimenting with recently, which amounts to a set of new APIs which proxy access to the media repository via an AV scanner server, whilst giving a way for clients to send encrypted E2E attachment keys to the AV scanner (if they want) so the scanner can scan the content before handing the response back to the client. https://github.com/matrix-org/matrix-content-scanner is the experimental implementation and contains the API doc which would need to make it into a MSC.
The text was updated successfully, but these errors were encountered: