Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions aren't encrypted in E2EE rooms. #2905

Closed
ara4n opened this issue Dec 14, 2020 · 5 comments
Closed

Reactions aren't encrypted in E2EE rooms. #2905

ara4n opened this issue Dec 14, 2020 · 5 comments

Comments

@ara4n
Copy link
Member

ara4n commented Dec 14, 2020

We should figure out how to do encrypted reactions in E2EE rooms properly and actually implement it.

@erkinalp
Copy link

Just encrypt them as if they were message events?

@t3chguy
Copy link
Member

t3chguy commented Dec 16, 2020

@erkinalp the server has to know which event they relate to so that it can give clients list of relations per-event. Also that isn't the issue, the issue is doing it whilst respecting some form of backwards compatibility as m.reaction didn't go through a sane speccing process.

@Sorunome
Copy link
Contributor

Relevant thoughts on this on a relevant MSC: #1849 (comment)

@Sorunome
Copy link
Contributor

Also duplicate of https://github.com/matrix-org/matrix-doc/issues/2678 ?

@uhoreg
Copy link
Member

uhoreg commented Dec 29, 2020

Also duplicate of matrix-org/matrix-spec#660 ?

Yes. I knew there was an issue for this already.

@uhoreg uhoreg closed this as completed Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants