Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmaintained dependency: backoff #4243

Open
poljar opened this issue Nov 11, 2024 · 3 comments
Open

Unmaintained dependency: backoff #4243

poljar opened this issue Nov 11, 2024 · 3 comments

Comments

@poljar
Copy link
Contributor

poljar commented Nov 11, 2024

The backoff crate seems to be unmaintained: ihrwein/backoff#66

The issue suggests the backon crate: https://docs.rs/backon/1.2.0/backon/.

backon isn't a drop-in replacement, but it seems to have WASM support, which means we could merge our HttpClient implementations.

@Xuanwo
Copy link

Xuanwo commented Nov 16, 2024

Hi, the maintainer of backon here. Let me know if you would like my assistance with the migration.

@poljar
Copy link
Contributor Author

poljar commented Nov 16, 2024

Ah, thanks for contacting us, we just didn't yet get to it.

One thing I didn't see in the docs is how to handle something like a 429 HTTP error which contains a Retry-After header.

This was added to backoff after a request from our side: ihrwein/backoff#35.

@Xuanwo
Copy link

Xuanwo commented Nov 16, 2024

Thank you @poljar for the information, I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants