Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Namespace Convention to Avoid Tag Name Conflicts Between Matomo Official Tags and Tag Manager Extended Community Plugin #954

Closed
Chardonneaur opened this issue Dec 13, 2024 · 6 comments
Labels
Enhancement New feature or request
Milestone

Comments

@Chardonneaur
Copy link
Contributor

Chardonneaur commented Dec 13, 2024

Hi Team,

This is an important issue.

Steps to reproduce

  • Have the last version of Matomo (5.2.0)
  • Update the Tag Manager Extended community plugin (on-premise).
  • Use the Axeptio community tag.

What I got:

  • The Axeptio community tag, even though it is more recent than the offcial Axeptio Matomo Tag.

What I expected instead:

  • A namespace convention should be implemented to avoid tag name conflicts, allowing both Matomo official tags and community plugin tags to coexist without overriding each other.

Who asked for it?

  • Ronan Hello, developer of the tag manager extended community plugin
add-namespace.mp4
@snake14 snake14 added this to the Backlog milestone Dec 15, 2024
@snake14 snake14 added the Enhancement New feature or request label Dec 15, 2024
@Stan-vw
Copy link

Stan-vw commented Dec 18, 2024

Thanks for the clear video. We're shipping a fix shortly.

@Chardonneaur
Copy link
Contributor Author

Thank you.

@AltamashShaikh
Copy link
Contributor

Adding a fix was more complicated in TagManager plugin, I have created a PR in TagManagerExtended plugin to filter out the newly created tags by TagManager plugin.

@Stan-vw
Copy link

Stan-vw commented Dec 18, 2024

@ronan-hello just following up on this: I understand it's working now, but let us know in case there's anything that's still going wrong. We appreciate the awesome work you're putting into MTM Extended.

@Stan-vw Stan-vw closed this as completed Dec 18, 2024
@Stan-vw
Copy link

Stan-vw commented Dec 22, 2024

btw I've closed this because I believe the immediate issue of this ticket was "there's currently a tag that doesn't work", which was fixed.
However, we've created a new ticket for the "long term" fix for a better Namespace convention: #963

@ronan-hello
Copy link

Hi @Stan-vw, thank you so much!
Yes, this issue is now fixed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants