Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Non-Interactive Dockerfile Hangs without TINI #121

Open
PVDecker1 opened this issue Oct 3, 2024 · 3 comments
Open

Default Non-Interactive Dockerfile Hangs without TINI #121

PVDecker1 opened this issue Oct 3, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@PVDecker1
Copy link

PVDecker1 commented Oct 3, 2024

The default entrypoint for the non-interactive dockerfile hangs for me, at least in my environment. I was able to get around this by incorporating the changes outlined here. Once applied, I no longer experienced the hang.

@prabhakk-mw
Copy link
Member

prabhakk-mw commented Oct 3, 2024

Hi @PVDecker1

Have you tried using the '--init' flag with your docker run command ?

docker run --init <rest of the command>

Does that also hang in your environment for the image not built with TINI directly?

@PVDecker1
Copy link
Author

PVDecker1 commented Oct 3, 2024

@prabhakk-mw, that seemed to do the trick. Seems to be a requirement in order to run this container. Would love to see it built into the container but at least I can make this work without injecting too much code. Thanks!

EDIT: I think the only reason I noticed this was that I did not have to pass the --init flag before, it was only the introduction of xvfb (which I am grateful for) that caused the built docker to stop working without the --init flag.

@prabhakk-mw
Copy link
Member

Thats great to hear!
This approach is documented in the main README of this repository.

I suspect the reason it is not built into the images is because tini is not available on all the flavors of linux that we were supporting at the time, and requires different installation steps based on the flavor of linux.

Also given that TINI is now natively built into Docker 1.13+ onwards through the --init flag we chose to document this in the README instead.

We will have another look at using TINI directly with as many entrypoints as we can.

Thank you for reaching out and sharing your feedback.

@prabhakk-mw prabhakk-mw self-assigned this Oct 3, 2024
@prabhakk-mw prabhakk-mw changed the title Default Non-Interactive Dockerfile Hangs Default Non-Interactive Dockerfile Hangs without TINI Oct 3, 2024
@prabhakk-mw prabhakk-mw added the enhancement New feature or request label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants