Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

License, Travis and Scrutinizer #5

Open
rdohms opened this issue Apr 6, 2015 · 5 comments
Open

License, Travis and Scrutinizer #5

rdohms opened this issue Apr 6, 2015 · 5 comments

Comments

@rdohms
Copy link
Contributor

rdohms commented Apr 6, 2015

Having all of these parts would greatly increase user's faith in this library.

May i recommend looking at https://github.com/thephpleague/skeleton and following how they do these?

Should be an easy fix. You already have tests, but i also think PSR-2 would be a good fit.

@mathiasgrimm
Copy link
Owner

Good Idea.
It's suppose to be PSR-2. Where it isn't?

@rdohms
Copy link
Contributor Author

rdohms commented Apr 6, 2015

Not saying it isn't but there is nothing checking it, might be worth mentioning also.

@mathiasgrimm
Copy link
Owner

Ok, will use the template, looks good.
Are you willing to send the PR?

@rdohms
Copy link
Contributor Author

rdohms commented Apr 7, 2015

I would not be able to test it all, all you need to do is copy the files and adjusts paths. The travis/scrutinizer side of it has to be done by the repo owner.

@mathiasgrimm
Copy link
Owner

mathiasgrimm commented Apr 7, 2015 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants