Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last remaining compiler warning in DMSSerial.cpp #21

Open
g0uus opened this issue Oct 30, 2018 · 2 comments
Open

Last remaining compiler warning in DMSSerial.cpp #21

g0uus opened this issue Oct 30, 2018 · 2 comments

Comments

@g0uus
Copy link

g0uus commented Oct 30, 2018

Sign/Unsigned comparison warning on line 791
for (int n = 0; n < _initData->additionalCommandsLength; n++) {

RDMINIT.additionalCommandsLength is declared as uint16_t

Simple fix is to replace int n by uint16_t n.

This is the last remaining Compiler warning in DMXSerial itself. The warnings from EEPROM.h have been fixed in ArduinoCors-Avr/Libraries/EEPROM.h but not yet released!

g0uus pushed a commit to g0uus/DmxSerial2 that referenced this issue Oct 30, 2018
@peternewman
Copy link
Contributor

This is the last remaining Compiler warning in DMXSerial itself. The warnings from EEPROM.h have been fixed in ArduinoCors-Avr/Libraries/EEPROM.h but not yet released!

Have you got a link to the EEPROM stuff? It's what's blocking one of my Travis builds somewhere, and if fixed would mean we could add warning/error checking here too (although it still needs enabling for the main repo).

@g0uus
Copy link
Author

g0uus commented Oct 30, 2018

arduino/ArduinoCore-avr@6848ea4

Actually released in Arduino AVR Boards 1.6.23 - just downloaded.
Building for Uno using Arduino 1.8.7.

I now get a single warning when building the RDMSerialRecv sample at EEPROM.h:145 that
static EEPROMClass EEPROM is unused :(

Haven't time to investigate at the moment though.

g0uus pushed a commit to g0uus/DmxSerial2 that referenced this issue Oct 31, 2018
mathertel added a commit that referenced this issue Jul 3, 2020
Fix compiler warning Issue #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants