-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last remaining compiler warning in DMSSerial.cpp #21
Comments
Have you got a link to the EEPROM stuff? It's what's blocking one of my Travis builds somewhere, and if fixed would mean we could add warning/error checking here too (although it still needs enabling for the main repo). |
arduino/ArduinoCore-avr@6848ea4 Actually released in Arduino AVR Boards 1.6.23 - just downloaded. I now get a single warning when building the RDMSerialRecv sample at EEPROM.h:145 that Haven't time to investigate at the moment though. |
Sign/Unsigned comparison warning on line 791
for (int n = 0; n < _initData->additionalCommandsLength; n++) {
RDMINIT.additionalCommandsLength
is declared asuint16_t
Simple fix is to replace
int n
byuint16_t n
.This is the last remaining Compiler warning in DMXSerial itself. The warnings from EEPROM.h have been fixed in ArduinoCors-Avr/Libraries/EEPROM.h but not yet released!
The text was updated successfully, but these errors were encountered: