Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need Coq.Program.Tactics. #85

Open
corwin-of-amber opened this issue Sep 27, 2021 · 3 comments
Open

Need Coq.Program.Tactics. #85

corwin-of-amber opened this issue Sep 27, 2021 · 3 comments

Comments

@corwin-of-amber
Copy link

In Coq 8.14 (rc1), I am getting this:

File "./finmap/finmap.v", line 752, characters 0-186:
Error: Library Coq.Program.Tactics has to be required first.

Indeed adding Require Coq.Program.Tactics. at the beginning of finmap.v solves the problem.

@ejgallego
Copy link
Contributor

@corwin-of-amber are you using the fast-load patch?

One of the effects the patch has is to remove that implicit import. I agree that it would be nice to make this dependency on Program explicit [IIRC it is due rewriting with the setoid for iff]

Please annoy me so upstream that fast-load patch for once and for all.

@corwin-of-amber
Copy link
Author

Oh yes! I completely forgot about that patch.

So that import comes from somewhere within (core) mathcomp I guess. Agreed, it should be here as well, anyway.

@ejgallego
Copy link
Contributor

So that import comes from somewhere within (core) mathcomp I guess. Agreed, it should be here as well, anyway.

It comes from a side effect of importing (non used) Coq arithmetic libs. That used to weight 100MiB so hence the reason I implemented that optimization. Will try to upstream that soon, sorry for the lag on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants