Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Mastodon's new ProjectModel #3

Closed
6 of 8 tasks
maarzt opened this issue Jan 3, 2024 · 1 comment · Fixed by #4
Closed
6 of 8 tasks

Adapt to Mastodon's new ProjectModel #3

maarzt opened this issue Jan 3, 2024 · 1 comment · Fixed by #4
Assignees

Comments

@maarzt
Copy link
Collaborator

maarzt commented Jan 3, 2024

The mastdon-git project is not compatible with the latest mastodon core version. It needs to be updated.

This issue is addressed in #4

Problem

Mastodon-git cannot be installed with the latest mastodon 1.0.0-beta-28. Fiji instead crashes and complains about undefined classes or undefined methods.

Expected Behavior

It should be possible to run mastodon-git with the latest mastodon 1.0.0-beta-28. All functions that are described in the documentation: How to share a Mastodon project? How to contribute to as share Mastodon Project? should work as expected.
(An SNAPSHOT version of mastodon-git and mastodon-collections is on the Maarzt update site. An up to date Fiji with 'TomancakLab' and 'Maarzt' update sites activate should allow to go through all the steps in the mastodon-git tutorials.)

TODOs

  • Make this repository compatible with mastodon version 1.0.0-beta-27 and the Mastodon-Dev Fiji update site.
  • Add a unit test to make sure everything still works. The unit test could simulate:
      1. creating a shared project
      1. cloning a share project
      1. two people contributing simultaneously
  • Problem: model.getGraph().notifyGraphChanged() needs to be called, after reload from disk, but this breaks the undo redo recorder as demonstrated in the failing UndoRedoTest. The problem is fixed in this PR Tiny change to fix UndoRedoStack.clear() mastodon-collection#16 and there are important unit tests in this PR: Add Unit Test to Thoroughly Tests Mastodon's Undo Redo Mechanism mastodon#289
  • Compile the JAR and put it on the "Maarzt" update site that also includes the dependencies.
  • Functional testing
  • test branches
  • ask for author name before "commit", "pull", "clone", when it hasn't been set.
  • fix typo in share project dialog
@maarzt
Copy link
Collaborator Author

maarzt commented Jan 3, 2024

  • Make sure the plugin still works if the dataset is not available on a specific machine:

Find a way to undo these changes: (call openWithDialog when reloading a Mastodon project)
24dd398#diff-a9ccbd89008809a2a88004294ab8cb578090ec58e31bcae89b3fb37bb073b4a6

Mastodon git now has a more fine grained reloading of a Mastodon project. The image data is not reloaded, only the Model (containing the ModelGraph and the TagSetModel) is reloaded. This solves the problems caused by attempting to reload missing image data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant