Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssr bundled Marko files in build mode #86

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

DylanPiercey
Copy link
Contributor

Description

Fixes a regression where SSR Marko files were not being bundled in build mode.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

🦋 Changeset detected

Latest commit: 80990eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (72035a8) 76.47% compared to head (80990eb) 75.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   76.47%   75.91%   -0.56%     
==========================================
  Files           9        9              
  Lines         544      544              
  Branches      124      124              
==========================================
- Hits          416      413       -3     
- Misses         82       83       +1     
- Partials       46       48       +2     
Files Coverage Δ
src/index.ts 73.52% <100.00%> (-0.85%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 701d0f9 into main Oct 13, 2023
10 of 11 checks passed
@DylanPiercey DylanPiercey deleted the fix-ssr-cjs-regression branch October 13, 2023 17:15
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant