Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse-node-args: parsing -r, -p, and -e won't work #5

Open
cspotcode opened this issue Oct 11, 2018 · 1 comment
Open

parse-node-args: parsing -r, -p, and -e won't work #5

cspotcode opened this issue Oct 11, 2018 · 1 comment

Comments

@cspotcode
Copy link

cspotcode commented Oct 11, 2018

parse-node-args

I don't think this line will work correctly:

https://github.com/marko-js/utils/blob/master/packages/parse-node-args/src/flags.js#L36

It creates a regexp meant to match two items in the argv array, but items are tested against the regexp in isolation.

@cspotcode cspotcode changed the title https://github.com/marko-js/utils/blob/master/packages/parse-node-args/src/flags.js#L36 parse-node-args: parsing -r, -p, and -e won't work Oct 11, 2018
@DylanPiercey
Copy link
Contributor

Hey, thanks for creating the issue. It seems to be working but I’ll take a closer look when I get some time. It would be very helpful if you are able to create a failing test for this case also 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants