Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout attribute does not apply to client side code #10

Open
mkchang opened this issue Nov 12, 2022 · 0 comments
Open

timeout attribute does not apply to client side code #10

mkchang opened this issue Nov 12, 2022 · 0 comments

Comments

@mkchang
Copy link

mkchang commented Nov 12, 2022

Version: 1.4.2

Details

timeout param does not currently trigger an AbortController signal in client side code, only applies in the <await> tag of server side code.

Expected Behavior

timeout param passed into micro-frame used on browser side should cause the fetch to be aborted, if no value is passed then the default 30s should apply.

Actual Behavior

micro-frame never times out, even if you specify a timeout value.

Possible Fix

A default AbortController is created, but it seems to only be used for onDestroy and onUpdate aborts, and does not make use of the timeout value (or 30s default). A setTimout or some other method could be used to trigger an AbortSignal.abort() if the time is reached

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant