Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS UIWebview replacement to WKWebview #415

Open
gurdeep2020 opened this issue Aug 6, 2020 · 4 comments
Open

iOS UIWebview replacement to WKWebview #415

gurdeep2020 opened this issue Aug 6, 2020 · 4 comments

Comments

@gurdeep2020
Copy link

Hi there,
I am reporting an issue with regards to UIWebview api used in this project. As Apple has deprecated the api UIWebview and replaced this with WkWebview. So any developer who will upload the iOS app to app store from December 2020 with UIWebview implementation will not be accepted.
So kindly please provide an updated WebViewJavascriptBridge version without the reference and usage of UIWebview. It will be greatly appreciated.

WVJB Bug Report

Thanks for reporting an issue with WebViewJavascriptBridge.

Do these 4 things and I will fix your problem!

  1. Go to https://github.com/marcuswestin/WebViewJavascriptBridge and click Fork.
  2. Clone your fork, cd into it and run make test. All tests should pass!
  3. Edit Tests/WebViewJavascriptBridgeTests/BridgeTests.m and create a new, failing test which demostrates your issue.
  4. Create a pull request for https://github.com/marcuswestin/WebViewJavascriptBridge

That's it!

I will take it from there and promise that I'll fix your problem ASAP.

If you don't do this then I can't help you!

And I probably won't :)

Cheers,
@marcuswestin

@luoshihui
Copy link

you can download the code, then delete the WebViewJavascriptBridge.h/.m file, then add others to your project.

@ajabade
Copy link

ajabade commented Sep 17, 2020

Hello Team,

I'm using this lib for WKWebView but still, this library has UIWebView references. As per Apple, they won't accept the app store update for UIWebView after Dec 2020.

Could you please remove references for UIWebView and update the library version?

Thank you so much!

@tc1993
Copy link

tc1993 commented Dec 10, 2020

您可以下载代码,然后删除WebViewJavascriptBridge.h / .m文件,然后将其他文件添加到您的项目中。

yes delete it and import WKWebViewJavascriptBridge replace it。 it‘s ok

@ajabade
Copy link

ajabade commented Dec 10, 2020

Thank you for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants