New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with issue detection in footer for org/user#issue #41

Open

brunob opened this issue Jun 3, 2022 · 1 comment

Labels

Contributor

brunob commented Jun 3, 2022 •

edited

Loading

Hi, issues like Fix: #XX are detected, but things like Fix: spip-team/securite#483 (aka org/repo#issue) are not. I think it's handled here https://github.com/marcocesarato/php-conventional-changelog/blob/main/src/Git/Commit/Footer.php#L54 but i'm not sure. edit : Reference class should also be ehanced for that.

Do you think it could be possible to enhance this ? Are maybe it's out of scope ?

The text was updated successfully, but these errors were encountered:

marcocesarato added the enhancement label

Contributor Author

brunob commented Jun 27, 2022

FTR, this regex should do the job '@(?:(?<![\/\w-.])\w[\w-.]+/\w[\w-.]+|\B)#[1-9]\d*\b@' ref https://regex101.com/r/SQrOlx/14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment