Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge into ESPHome Core? #5

Open
BradleyFord opened this issue Jan 12, 2024 · 3 comments
Open

Merge into ESPHome Core? #5

BradleyFord opened this issue Jan 12, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@BradleyFord
Copy link

Would it be possible to have this added directly into ESPHome?

Also it is really great that this in ESPHome, it is now super easy to setup and get running.

@mapero
Copy link
Owner

mapero commented Jan 12, 2024

I guess it needs some more work on the modbus stuff. Needs to use the modbus component from esphome. Currently it uses the modbus code from the hcpbridge.

I definitely have this on the list, but currently I am a little time constraint. Since it is working fine at the moment, this is not my highest priority project ;)

@mapero mapero added the enhancement New feature or request label Jan 12, 2024
@jkaberg
Copy link

jkaberg commented May 22, 2024

Now that esphome/esphome#4874 (comment) is merged this should possibly be easier?

@14yannick
Copy link

I had a look on the esphome modbus component. but I think at the moment not all needed functionality are present there.
In the source code there is mentioned that the needed modbus fuction Read write multiple register is not implemented.
This implementation is definitively above my capability.
READ_WRITE_MULTIPLE_REGISTERS = 0x17, // not implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants