Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GPT3CompletionModel to something more accurate #74

Open
falquaddoomi opened this issue Jan 15, 2025 · 0 comments
Open

Rename GPT3CompletionModel to something more accurate #74

falquaddoomi opened this issue Jan 15, 2025 · 0 comments
Assignees

Comments

@falquaddoomi
Copy link
Collaborator

Near the creation of the tool, the revision model that integrates with an external LLM has been named GPT3CompletionModel. Since that choice was made, OpenAI has released various new versions of GPT, e.g. GPT-3.5, GPT-4, GPT-4o, etc. Also, since PR #60, the model has been updated to work with other LangChain-compatible providers, e.g. Anthropic's Claude, that don't refer to their LLMs as GPTs at all.

It would be good to rename this class to something that captures that it works with any supported provider/LLM, and that it's the main class that's used for revisions; unlike the other descendants of ManuscriptRevisionModel, it isn't just for testing. Perhaps LLMCompletionModel could work?

Since https://github.com/manubot/manubot references GPT3CompletionModel in several places, we'll have to have a PR in that repo as well that introduces the renamed class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant