Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change routine for y-space fit #113

Open
5 tasks
GuiMacielPereira opened this issue Jun 28, 2024 · 0 comments · May be fixed by #111
Open
5 tasks

Change routine for y-space fit #113

GuiMacielPereira opened this issue Jun 28, 2024 · 0 comments · May be fixed by #111
Assignees
Labels
enhancement New feature or request vesuvio-analysis

Comments

@GuiMacielPereira
Copy link
Collaborator

Current routine has a few shortcomings:

  • Option to symmetrise the data is not ideal, and should be replaced by subtracting FSE to the first NCP peak
  • Errors on the parameters, especially for functions like GC_C4, GC_C6 and GC_C4_C6 are often on the same magnitude of the parameter values, which invalidates the fit
  • Global fit on all detectors is slow
  • Positivity constraint is not being successfully implemented, since some fitted functions have negative values

Possible solutions and avenues to explore:

  • Implement FSE corrections before focusing data
  • Instead of convolving NCP to fit, deconvolve the data and fit NCP
  • Explore using Mantid algorithm for plotting the error profiles of the parameters, maybe an alternative to using MINOS?
  • Use Mantid Fit for global fit instead of using iminuit
  • Use analytical solutions for the positivity constraints where possible, resort to brute force numerical range constraint for GC_C4_C6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vesuvio-analysis
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant