Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PolarizationCorrectionWildesTest to reduce code duplication #38326

Open
rbauststfc opened this issue Oct 30, 2024 · 0 comments · May be fixed by #38529
Open

Refactor PolarizationCorrectionWildesTest to reduce code duplication #38326

rbauststfc opened this issue Oct 30, 2024 · 0 comments · May be fixed by #38529
Assignees
@yusufjimoh
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Reflectometry Issues and pull requests related to reflectometry SANS Issues and pull requests related to SANS
Milestone
Release 6.12

Comments

@rbauststfc
Copy link
Contributor

Some refactoring of the unit tests in class PolarizationCorrectionWildesTest has already been done under #37294, and significant improvements were made. I think we can continue to build on that to try and further reduce the amount of code duplication that remains.
@rbauststfc rbauststfc added Reflectometry Issues and pull requests related to reflectometry SANS Issues and pull requests related to SANS Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS labels Oct 30, 2024
@rbauststfc rbauststfc added this to the Release 6.12 milestone Oct 30, 2024
@rbauststfc rbauststfc moved this from New to Backlog in ISIS LSS Sprint Planning Oct 30, 2024
@rbauststfc rbauststfc moved this from Backlog to In Progress in ISIS LSS Sprint Planning Dec 13, 2024
@yusufjimoh yusufjimoh linked a pull request Dec 18, 2024 that will close this issue
Refactor WildesTest to reduce Code Duplication #38529
Open
@yusufjimoh yusufjimoh linked a pull request Dec 18, 2024 that will close this issue
Open
@rbauststfc rbauststfc moved this from In Progress to Review in ISIS LSS Sprint Planning Jan 7, 2025
@rbauststfc rbauststfc moved this from Review to In Progress in ISIS LSS Sprint Planning Jan 8, 2025
@rbauststfc rbauststfc moved this from In Progress to Review in ISIS LSS Sprint Planning Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yusufjimoh yusufjimoh

Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Reflectometry Issues and pull requests related to reflectometry SANS Issues and pull requests related to SANS
Projects
ISIS LSS Sprint Planning
Status: Review
Milestone
Release 6.12
Development

Successfully merging a pull request may close this issue.

Refactor WildesTest to reduce Code Duplication mantidproject/mantid
2 participants
@rbauststfc @yusufjimoh