Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russell's TakeAway Challenge #2228

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Rmorbey
Copy link

@Rmorbey Rmorbey commented May 2, 2022

Russell's TakeAway Challenge

Please write your full name here to make it easier to find your pull request.

User stories

Please list which user stories you've implemented (delete the ones that don't apply).

  • User story 1: "I would like to see a list of dishes with prices"
  • User story 2: "I would like to be able to select some number of several available dishes"
  • User story 3: "I would like to check that the total I have been given matches the sum of the various dishes in my order"
  • User story 4: "I would like to receive a text such as "Thank you! Your order was placed and will be delivered before 18:52" after I have ordered"

README checklist

Does your README contains instructions for

  • how to install,
  • how to run,
  • and how to test your code?

Here is a pill that can help you write a great README!

@@ -20,6 +20,6 @@ def view_dishes
end

def check_if_available(item)
return 'That dish is not available. Please select another dish.' if @dishes[item].nil?
raise 'That dish is not available. Please select another dish.' if @dishes[item].nil?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are both of these messages needed? Would just the 'raise' message work without the return one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants