Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file submission with special characters will fail to download #189

Open
RA341 opened this issue Nov 12, 2024 · 0 comments
Open

file submission with special characters will fail to download #189

RA341 opened this issue Nov 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@RA341
Copy link
Collaborator

RA341 commented Nov 12, 2024

Subject of the issue


When making a file submissions, if the file name contains special characters, it will no longer be able to be downloaded, since the path will be different in multer and what we store in the database

Expected behaviour


The filename should be URL encoded before uploading and the same string should be stored in the database

Actual behaviour


The file name is stored without encoding

Steps to reproduce


Make a file submission to an assignment that contains special characters or spaces "hello_ world"
try to retrieve this file using
localhost:3001/course/1/file-upload/

@RA341 RA341 added the bug Something isn't working label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant