Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Allow GDPR settings to use cookie value as-well as checking for cookie #80

Open
GaryHaddon opened this issue Oct 18, 2023 · 2 comments

Comments

@GaryHaddon
Copy link

Magento version #: 2.4.6-p3

Edition (EE, CE, OS, etc): CE

Add support for cookie groups in GDPR settings. e.g

image

This can be achieved by adding an additional option to the GDPR settings to allow checking for active group in cookie values. e.g:
image

Proposed patch attached and PR created referencing this issue.

Add_cookie_group_option.patch

@GaryHaddon
Copy link
Author

I have expanded on the functionality to cover more use cases

I think we need to support combinations of the following.

"cookies allowed": {"marketing":1,"performance":0}

"cookies allowed": {"marketing","performance"}

"cookies allowed": "all"

"cookies allowed": {"all"}

We should also probably support the inverse too for opt out scenarios.

"cookies rejected": {"marketing":1,"performance":0}

"cookies rejected": {"marketing","performance"}

"cookies rejected": "all"

"cookies rejected": {"all"}

A lot of the cookie modules we have tried seem to work differently but all have a combination of cookie groups stored in an array (with or without a true/false flag).

image

Patch Below:
google-tag-manager--gdpr-check-cookie-value.patch

@GaryHaddon
Copy link
Author

GaryHaddon commented Oct 24, 2023

Fix for non JSON cookie values

google_tag_manager__cookie_value_check.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant