-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write a Github Action that runs the the semantic version checker as defined by https://developer.adobe.com/commerce/testing/guide/svc/ #5
Comments
So, the semver checker tool wants to compare whatever changes you have against a known version or tag. I don't see a way to have it auto-determine which version your new change or branch should validate against, so should I just hard-code it to From the instructions:
|
Unrelated question: Check semver on every push, on pull requests, what trigger do we want to use? |
On PRs only currently, comparing the diff of the PR against the original HEAD. |
See the following potential pull request into the MageOS repo: 2.4-develop...lefte:magento2:feature/issue-5-github-action-semantic-checker Would this be the right spot to create a PR to? |
Hopefully this is what you meant, it compares the new pull request's head branch against the base branch |
@lefte this is exactly it! Thank you so so so much! |
🚯 Ah, I see it doesn't like pull requests from forked repositories, let me check on which variable to use for that |
Alright, I believe the newest action https://github.com/mage-os/mageos-magento2/actions/runs/3374600139 should now work with forked repositories. Thanks for your patience. |
…tic-checker Issue #5 GitHub Action Semantic Checker
No description provided.
The text was updated successfully, but these errors were encountered: