Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement request for MT.1024 #489

Open
weyCC81 opened this issue Oct 7, 2024 · 1 comment
Open

Improvement request for MT.1024 #489

weyCC81 opened this issue Oct 7, 2024 · 1 comment

Comments

@weyCC81
Copy link
Contributor

weyCC81 commented Oct 7, 2024

Situation
Is it possible to assign a specific tag to each recommendation, so a specific recommendation can be excluded?

Reason: I have a cloud only environment
MT.1024: Entra Recommendation - Enable password hash sync if hybrid.

You have disabled password hash sync.

Reason: No license planned
MT.1024: Entra Recommendation - Protect all users with a sign-in risk policy.
MT.1024: Entra Recommendation - Protect all users with a user risk policy .

You have X of X users that don't have a sign-in risk policy turned on.

Experiment
I have set one to "Dismiss recommendation" and another one to "Postpone recommendation" may this could provide me with a workaround on a per-tenant level... --> current state is not taken into account (may also better like this)

@weyCC81
Copy link
Contributor Author

weyCC81 commented Oct 7, 2024

I would have a fix, but don't know how to create a pull request (PR), the view is also limited by #411

## Should add
#It "MT.1024: Entra Recommendation - <displayName>. See https://maester.dev/docs/tests/MT.1024" -Tag "MT.1024" {
It "MT.1024: Entra Recommendation - <displayName>. See https://maester.dev/docs/tests/MT.1024" -Tag "MT.1024", $recommendationType {

## May add (Workaround for #411)
#$ResultMarkdown = $insights + $impactedResourcesList + "`n`n#### Remediation actions:`n`n" + $ActionSteps
$ResultMarkdown = $insights + $impactedResourcesList + "`n`n#### Remediation actions:`n`n" + $ActionSteps + "`n`n ExcludeTag: $($recommendationType)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant