-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tesseract for testing #216
Comments
FYI, Xenial is 16.04, not 18.04: http://releases.ubuntu.com/16.04/ It does look like Bionic was recently added to Travis CI: https://docs.travis-ci.com/user/reference/bionic/ So it should be as simple as bumping up the In general I think testing against a newer |
Hmm, do we want to support Tesseract 3? If so, we should use Xenial, because it has still prebuilds of Tesseract 3. Otherwise we have to compile it manually or skip this version. In general I prefer the support of both versions 3 and 4. Image:
Image
Yes, we can try to avoid a Docker image by using further environment variables. The following configuration is a simple draft to demonstrate the idea how to run the unit tests against Tesseract 3 and 4:
|
What if instead of a custom PPA, we put both xenial and bionic in the |
It's a good idea, but I have never seen a configuration where the distribution is configured by an environment variable form a matrix. And I couldn't find any informations about that. |
Perhaps this? https://docs.travis-ci.com/user/multi-os/#example-multi-os-build-matrix matrix:
include:
- os: linux
dist: trusty
- os: osx
osx_image: xcode7.2 Maybe we could do something like: matrix:
include:
- os: linux
dist: xenial
- os: linux
dist: bionic |
That looks good! But do we have to combine these?
Can you try it out on a separate branch? Travis will checkout this new branch and run the tests. |
If you create a PR, Travis will run with your updates to the Travis config if you want to try it out. |
The build looks good (120988151), but we have to open issues:
|
About 2. - I don't think that it will be a big problem if some use cases fail (I don't think that will hit the exotic scenarios). We have support only for the basic functionality |
I think it's fine if we don't test Python 3.5 on Bionic as long as it's tested on Xenial. With the different |
I think this is fine as well. The fact that we're doing any testing in this area is a huge improvement, so I think it's still a great step forward. I doubt that |
Yesterday I tested the original images from Ubuntu (https://hub.docker.com/_/ubuntu). By using If the beta version is fine, you can merge the PR 😃. Otherwise we can create a small Docker image. |
@int3l I don't have a strong preference, but I'd recommend we just use the stock beta version to keep the Travis configuration simpler. |
Yep, that's fine by me. |
Hello,
it would be great if we could add the next stable version of Tesseract for testing. In addition we could update the version of the operating system. I mean, why not 😌?
Reasons:
Solution:
We could use Travis to test
pytesseract
with Tesseract-OCR 3.04.01 and 4.1.0 on Bionic 18.04 using a simple Dockerfile. I can do that and create a PR, but in this case it would be great to get some opinions first.Edit:
Fix and change Xenial version from 14.04 to 16.04.
The text was updated successfully, but these errors were encountered: