Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 404 error #13

Open
Valve opened this issue Aug 20, 2018 · 4 comments
Open

Improve 404 error #13

Valve opened this issue Aug 20, 2018 · 4 comments
Assignees
@drnluz

Comments

@Valve
Copy link
Contributor

Valve commented Aug 20, 2018

Today I was using this gem and it returned 404 error for all my requests. I didn't know why.
Only when I opened the raw_response, I saw that it has this body:

   <html>\n

<head>\n
  <meta http-equiv=\ "Content-Type\" content=\ "text/html;charset=utf-8\"/>\n
  <title>Error 404 Not Found</title>\n
</head>\n

<body>
  <h2>HTTP ERROR 404</h2>\n
  <p>Problem accessing /solr/parts/parts/select. Reason:\n
    <pre>    Not Found</pre>
  </p>\n
</body>\n

</html>

We should be able to see exact 404 message, in this case: "

Problem accessing /solr/parts/parts/select. Reason:\n

    Not Found
"

Let's not work on it, if it's complex to do w/out an HTML parser
@syabruk
Copy link
Member

syabruk commented Aug 20, 2018

Did you use master?

@Valve
Copy link
Contributor Author

Valve commented Aug 20, 2018

Yes

@drnluz
Copy link
Contributor

drnluz commented Aug 21, 2018

@Valve We would need an HTML parser because solr returns an empty 404 response body when using Accept: application/json header

@Valve
Copy link
Contributor Author

Valve commented Aug 21, 2018

@drnluz let's not worry about it for now then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drnluz drnluz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Valve @syabruk @drnluz