Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup needed: contents of SW/MK directory outdated #11

Closed
mhaberler opened this issue Apr 16, 2016 · 8 comments
Closed

cleanup needed: contents of SW/MK directory outdated #11

mhaberler opened this issue Apr 16, 2016 · 8 comments

Comments

@mhaberler
Copy link
Contributor

SW/MK contains lots of dead bodies and duplication:

the hm2_soc.c/h ll hostmot driver is superseded which already goes into the mk packages and works

hm2_socfpga-mk.patch is merged

Same for kernel-drivers::

the only one needed is hm2reg_uio - the status of the other stuff is unclear and I am not sure work-in-progress code should be in a machinekit organisation repo

also, I came up with the dkms wrappings for hm2reg_uio and adcreg_uio - this is the preferred method for any kernel drivers downstream

do the Makefile.tar.gz serve any purpose (?)

same for the config - already in mk/mk

proposal:

  • I transfer to https://github.com/mhaberler/machinekit-dkms and we setup the package build from there (not sure if adcreg should be built if there is no using HALcomp)
  • any development work for any kmods happens there
  • delete SW/MK subtree in toto save for a note on the required kernel config options

@the-snowwhite - as the adcreg code matures:

  • kmod updates go to mk/machinekit-dkms via PR
  • HAL comps and other working stuff like configs goes to mk/mk via PR

Also, documentation should go into docs proper but that needs a bit of organizing first

@mhaberler
Copy link
Contributor Author

update: just transferred https://github.com/machinekit/machinekit-dkms

@the-snowwhite
Copy link
Contributor

Note:
I never got the adc_uio to work in any way:
I seems like a bad idea to use uio to interface to a 2 16-bit reg fifo ?


adcreg is the driver that functions:
https://github.com/machinekit/mksocfpga/tree/master/SW/MK/kernel-drivers/adcreg

adcfs contains the c++ (api) and userspace test programs that work with it.
https://github.com/machinekit/mksocfpga/tree/master/SW/MK/kernel-drivers/adcfs

@mhaberler
Copy link
Contributor Author

@the-snowwhite - I propose to go ahead with the cleanup as outlined above

if no objectsion I will file a PR.

@mhaberler
Copy link
Contributor Author

right, but that should be a normal HAL component and posted as PR against mk/mk - the dkms repo is the wrong place for this, as is the mksocfpga repo

@the-snowwhite
Copy link
Contributor

@cdsteinkuehler
Copy link
Contributor

AFAIK, the kernel driver isn't really needed, the generic UIO drivers already in the kernel will allow direct memory access and interrupts with a proper device tree overlay. The device-tree example is useful in theory, but what's in the repo is undocumented and not particularly helpful.

IMHO, only the mksocmemio and uio_irq_test are likely to be useful.

the-snowwhite added a commit to the-snowwhite/mksocfpga that referenced this issue May 9, 2019
Signed-off-by: Michael Brown <[email protected]>
@the-snowwhite
Copy link
Contributor

the-snowwhite commented May 9, 2019

ok
Yes I agree
#47

I'm currently compiling some documentation (from recent threads on the google group) and expect to commit a sketch soon to and upodated fork the docs repo (hope for some feedback on that).

Also in works is a pure cleanup commit to get rid of the "old fuzz".
https://github.com/the-snowwhite/mksocfpga/tree/cleanup_work

BTW: the mksocmemio utility has mananged to "sneek" in:
https://github.com/machinekit/machinekit-hal/blob/master/src/hal/utils/mksocmemio.c

So I guess its safe to delete that folder also.... as long as I remember to put the documentation somewhere ?

the-snowwhite added a commit to the-snowwhite/mksocfpga that referenced this issue May 9, 2019
Signed-off-by: Michael Brown <[email protected]>
cdsteinkuehler added a commit that referenced this issue May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants