We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whenever a new machine is created, the Boot2Docker ISO is downloaded, even the newest one has been cached (cf. docker/machine#4058).
Only the 3 digits of the version number are considered when extracted from the ISO: https://github.com/zchee/docker-machine-driver-xhyve/blob/a2060c0729fc92f98265d85bdaed6dd88562bf15/b2d/b2d.go#L219 while the actual (and encoded) version number may be suffixed (e.g. with "-ce" in v17.07.0-ce ISO file version). Thus for the v17.07.0-ce ISO file, the version is parsed as 17.07.0 while the advertised one (in https://api.github.com/repos/boot2docker/boot2docker/releases/latest) is 17.07.0-ce, hence a mismatch and hence a download.
v17.07.0-ce
17.07.0
17.07.0-ce
It is weird that the docker-machine source code implementation for that extraction, which differs, is broken as well.
docker-machine
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Symptom
Whenever a new machine is created, the Boot2Docker ISO is downloaded, even the newest one has been cached (cf. docker/machine#4058).
Root cause
Only the 3 digits of the version number are considered when extracted from the ISO:
https://github.com/zchee/docker-machine-driver-xhyve/blob/a2060c0729fc92f98265d85bdaed6dd88562bf15/b2d/b2d.go#L219
while the actual (and encoded) version number may be suffixed (e.g. with "-ce" in
v17.07.0-ce
ISO file version).Thus for the
v17.07.0-ce
ISO file, the version is parsed as17.07.0
while the advertised one (in https://api.github.com/repos/boot2docker/boot2docker/releases/latest) is17.07.0-ce
, hence a mismatch and hence a download.It is weird that the
docker-machine
source code implementation for that extraction, which differs, is broken as well.The text was updated successfully, but these errors were encountered: