New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overload functions with an out parameter #9

Open

dmoisset opened this issue Jul 26, 2016 · 0 comments

Labels

Contributor

dmoisset commented Jul 26, 2016

Some functions like:

    def all(self, axis: AxesType=None, out: '_ArrayLike[_U]'=None, keepdims: bool=False) -> Union['_ArrayLike[_U]', '_ArrayLike[bool]']: ...

Should actually be defined as:

    @overload
    def all(self, axis: AxesType=None, keepdims: bool=False) -> '_ArrayLike[_S]: ...
    @overload
    def all(self, axis: AxesType=None, keepdims: bool=False, out: '_ArrayLike[_U]') -> '_ArrayLike[_U]: ...

But that's not working correctly because of python/mypy#1907

dmoisset added the upstream label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment