Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error message in flattener /catching the wrong exception #5

Open
dmoisset opened this issue Apr 9, 2014 · 0 comments
Open

Comments

@dmoisset
Copy link
Contributor

dmoisset commented Apr 9, 2014

At

https://github.com/machinalis/featureforge/blob/develop/featureforge/flattener.py#L197 , TypeErrors are caught. The call to next() triggers feature evaluation, and when the call to a feature raises a TypeError, that exception is caught and a ValueError("Cannot fit with an empty dataset") message is generated.

There's no reson to relaunch that exception with that message, the original exception should go through

From what I see in the history, the TypeError guard was there to catch possible problems when calling iter(...), but the call to iter() was moved outside the protected block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant