Powershell code execution #256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paving the way for Windows-specific tests
| @@ -50,6 +51,10 @@ var Languages = map[string]Language{ | |||
| Extension: "fish", | |||
| Commands: cmds{{"fish", "<file>"}}, | |||
| }, | |||
| Powershell: { | |||
| Extension: "ps1", | |||
| Commands: cmds{{"powershell", "-File", "<file>"}}, | |||
There was a problem hiding this comment.
Suggested change
| Commands: cmds{{"powershell", "-File", "<file>"}}, | |
| Commands: cmds{{"powershell", "-NoLogo", "-NoProfile", "-File", "<file>"}}, |
You probably want to add NoLogoand NoProfile to make things faster and safer. I would also recommend using pwsh since that would work cross platform. I suspect the type of user who wants this tool would be using Pwsh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229, partially? I didn't look at Command Prompt.
Changes Introduced
ctrl+eto execute PowerShell code blocksslidesblocks Windows from accessing the filemake teston different OS platforms