You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix: Add pthread support flag to Makefile
Specifically, I appended "-pthread" to the CXXFLAGS option (line 59) of firmware/test/nbproject/Makefile-Debug.mk. One should also add this to the release build appropriately.
2. Some tests fail
"dist/Debug/MinGW-Windows/test"
[==========] Running 145 tests from 15 test cases.
[----------] Global test environment set-up.
[----------] 9 tests from CircularBufferTest
[ RUN ] CircularBufferTest.CannotReadWhenEmpty
[ OK ] CircularBufferTest.CannotReadWhenEmpty (0 ms)
.
.
.
[----------] 6 tests from CreateFSTest
[ RUN ] CreateFSTest.FilesystemIsPersisted
Created filesystem
Created file
asserted File exists
Created filesystem2
Created checkFileExists
[ OK ] CreateFSTest.FilesystemIsPersisted (1 ms)
[ RUN ] CreateFSTest.FilesystemIsPersisted2
Segmentation fault (core dumped)
make: *** [test] Error 139
The text was updated successfully, but these errors were encountered:
For the first item, is it appropriate to add -pthread to both Makefile-Debug and Makefile-Release? I am just hoping it won't screw up things for other OS's as you Matt obviously didn't need it.
I'll try adding pthread when I'm working on this library next. I don't think it will have any affect on other platforms, where it's probably (hopefully!) just ignored. I've not yet tried flashee on OSX, which is now my day-to-day platform.
There are two issues.
1. gtest.h requires pthread support
Fix: Add pthread support flag to Makefile
Specifically, I appended "-pthread" to the CXXFLAGS option (line 59) of firmware/test/nbproject/Makefile-Debug.mk. One should also add this to the release build appropriately.
2. Some tests fail
The text was updated successfully, but these errors were encountered: