Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't treat every partition that can be unmounted as "removable media". #67

Open
Adityashaw opened this issue Dec 15, 2020 · 0 comments

Comments

@Adityashaw
Copy link

Almost every partition (other than root and home) can be unmounted and they're treated as removable media.

Why is this a problem?

If I check the option Preferences -> Behaviour -> Erase files on removable media instead of "trash can" creation then I am unable to use trash even on my HDD and SSD partitions which are essentially on the same disk as my root and home partitions.

Possible solution

Change this line : https://github.com/lxde/libfm/blob/master/src/job/fm-file-ops-job-delete.c#L351
to something that can detect the underlying disk as removable or not...
I don't know if it is possible or not...
Thanks!
Please ask if additional information is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant