Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http redirects are silently allowed #35

Closed
Tieske opened this issue Mar 8, 2015 · 2 comments · May be fixed by #36
Closed

http redirects are silently allowed #35

Tieske opened this issue Mar 8, 2015 · 2 comments · May be fixed by #36

Comments

@Tieske
Copy link
Member

Tieske commented Mar 8, 2015

See these lines; https://github.com/brunoos/luasec/blob/1ab6fac9197b194ea94166dff7ad81579f6113ed/src/https.lua#L122-L123

LuaSocket http module blocks redirects only if url.redirect is explicitly set to false. Hence the test here, allows nil to pass and makes LuaSocket execute the redirect.
Tieske added a commit to Tieske/luasec that referenced this issue Mar 8, 2015
@Tieske
fix silently redirecting
dce7073 
fixes lunarmodules#35

I suspect this will break a lot of existing code. Not nice, but probably for the better.
@Tieske Tieske mentioned this issue Mar 8, 2015
Open
@brunoos
Copy link
Member

brunoos commented Mar 12, 2015

Since LuaSec does not support redirects, would it be better to keep as it is now?

And, when we solve the redirect problem in LuaSec, do we adopt the same semantics as LuaSocket?

@Tieske
Copy link
Member Author

Tieske commented Mar 14, 2015

Let's close this in favour of the discussion in #34

@Tieske Tieske closed this as completed Mar 14, 2015
@Tieske Tieske mentioned this issue Mar 15, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix silently redirecting Tieske/luasec
2 participants
@Tieske @brunoos