-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom diffs #10
Comments
There are plans to extend the diffs further back at some point. The reason they stopped at CON is mostly that starting with Born of the Gods, the text files have some really scuffed formatting, and while that's definitely not an insurmountable problem, I didn't really have time to deal with it before launch. As far as dynamically generated diffs, that's something I remember discussing with Vill years ago, I think he even spent some time trying to implement it, but ultimately scrapped the idea. Some of my thoughts as to why I'm reluctant to try it at the moment:
All in all, doing this, and especially doing this right, would be a sizeable effort in return for a benefit that I'm not sure I really see. I might change my mind in the future, but for now this is nowhere near my list of priorities. |
I was more thinking judges, but I agree it's a very small demographic regardless. Agreed that this seems likely not worth the benefit overall. |
Right now the diffs only go back to Conspiracy, and they only cover a single set of changes. Instead, let users choose any two sets, and it generates a diff between them. This would be very useful for anyone getting back into Magic after taking a break, since they could look at a single diff covering all the changes since they left rather than needing to go through several individual ones. It would also simplify the UI, since you'd no longer need to display a long list of all available diffs.
The text was updated successfully, but these errors were encountered: