Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript Plugin #5

Closed
2 of 3 tasks
lukeed opened this issue Aug 29, 2018 · 3 comments
Closed
2 of 3 tasks

TypeScript Plugin #5

lukeed opened this issue Aug 29, 2018 · 3 comments
Labels
NEW plugin Related to a "plugin" package
Milestone
0.5.0

Comments

@lukeed
Copy link
Owner

lukeed commented Aug 29, 2018

  • Should include .tsx? as module extension
  • Should swap out babel-loader for itself
  • Should expect typescript config key?
    The standard TS config/rc file already works.

I think there may need to be separate @pwa/plugin-{preset}-typescript plugins for (React/Vue/etc)-specific handling of TypeScript. Same goes with test suite(s).
@lukeed lukeed added NEW plugin Related to a "plugin" package labels Aug 29, 2018
@lukeed lukeed added this to the 0.3.0 milestone Sep 5, 2018
@lukeed lukeed mentioned this issue Sep 7, 2018
Open
@olso
Copy link
Contributor

olso commented Sep 11, 2018

How is this looking ❤️

@lukeed
Copy link
Owner Author

lukeed commented Sep 11, 2018

@olso Great, actually! I was tempted to force it into 0.3.0 but making it a key feature of the next minor release.

I want to bundle in TS, TSLint, and ideally an Angular preset (#8) into 0.4.0. That'd make for a good milestone, I think 😄

@TzviPM
Copy link

TzviPM commented Nov 28, 2018

Hey @lukeed, I'd love to get involved with this project. Do you have a contributing guide / slack channel / something?

@lukeed lukeed closed this as completed in 48c3321 Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NEW plugin Related to a "plugin" package
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
3 participants
@TzviPM @lukeed @olso