Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TagKey convenience methods in TagSupplier.TagBakery #161

Open
XFactHD opened this issue Oct 4, 2024 · 0 comments
Open

TagKey convenience methods in TagSupplier.TagBakery #161

XFactHD opened this issue Oct 4, 2024 · 0 comments

Comments

@XFactHD
Copy link
Contributor

XFactHD commented Oct 4, 2024

TagSupplier.TagBakery currently requires the user to manually prefix the tag location given to queue(RL, RL) and queue(RL, Set<RL>) with the tag type folder name. It would be useful to have overloads of those two methods that take a ResourceKey<Registry<T>> and a TagKey<T> instead of the folder-prefixed tag location and then use Registries.elementsDirPath() to add the folder prefix. This would make the tag generator a bit more ergonomic to use, would avoid mistakes if Mojang decides to change folder names again and also ensures that generating tags for non-vanilla registries correctly prefixes the folder with the registry's namespace on NeoForge (I don't know whether Fabric or Quilt have similar prefixing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant