-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port bash scripts to PowerShell for Windows #872
Comments
@mdwagner I'm really not understanding how this Earthly stuff will work with Windows and the static fixtures. If you happen to find yourself bored sometime, I'd love a second set of eyes on this 😄 |
Ref: #867 (comment)
This whole setup script process currently runs several compilations anyway. I think moving to a single Crystal script that just calls the tasks directly would actually make the whole thing faster. Process.run("shards install")
puts "Installing node dependencies"
Process.run("yarn install --no-progress")
Process.run("yarn dev")
# this replaces lucky db.create, lucky db.verify_connection, and lucky db.migrate
Db::Setup.new.call
Db::Seed::RequiredData.new.call
Db::Seed::SampleData.new.call |
I just thought of a downside to this.... One of my favorite features in Lucky is when I go to boot my app on monday morning for work, and it stops to tell me I haven't started all of the necessary services I need to run the app. This is especially great because it takes my app 2 minutes to compile and boot, and waiting that time just to find out redis isn't running would be very annoying....
Now if we move this to Crystal, that means this will take a lot longer to run. On smaller apps it would be negligible, but in larger apps you may be waiting a minute just to find out stuff needs to boot... I guess we just run with this for now and see how it goes. Edit Well, this is surprising, and maybe this can't be directly related, but here's a fresh 1.3.0 app running the setup script as it currently stands:
And here is my take on the Crystal version of this
One thing I realized is I can't use the I still think we'll see some issues with |
Required for #868 we need to have all of the bash scripts used for setting up the Lucky app ported over to PowerShell for Windows.
The text was updated successfully, but these errors were encountered: