Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating LuckyTask broke Gen::Task #1834

Closed
jwoertink opened this issue Sep 21, 2023 · 1 comment
Closed

Updating LuckyTask broke Gen::Task #1834

jwoertink opened this issue Sep 21, 2023 · 1 comment
Labels

Comments

@jwoertink
Copy link
Member

In luckyframework/lucky_task#10 we had the issue of people wanting to use --name as an arg, but you couldn't because LuckyTask used it. So I renamed it to task_name thinking "yeah, no one will use that"

... except us 🤦‍♂️

positional_arg :task_name, "The name of the task to generate"

so now this doesn't work 😩

I can either revert that change on LuckyTask... or I guess use something other than task_name, or I just rename this one here which kind of becomes a breaking task, though I have a feeling it's not widely used..

@jwoertink
Copy link
Member Author

This was actually fixed in luckyframework/lucky_task#25 LuckyTask now uses class methods to avoid collisions with instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant