v0.24.0 -> v0.25.0 Upgrade Notes for Release

[robacarp]

This is a list of the issues I faced updating my app from lucky release 0.24.0 to master on lucky and avram.

Upgrade notes:

• with_defaults renamed to tag_defaults Rename with_defaults to tag_defaults #1262 - easy search and replace
• Avram::Operation now declares an abstract #run method which changes the interface a bit:
  • generated operations for ResetPasswordRequest and SignInUser need to be updated
  • generated actions for PasswordResetRequests::Create and SignIns::Create need to be updated
• has_many through: association declarations need minor updating.
• belongs_to join-querying need minor correcting

Annoyances:

• Log spammed by "Executing query" debug messages from Crystal DB - update to generated code - pull request

Resolved:

• resolved by Add back Avram::Model#to_param avram#559. As of Clean up Avram::Model to prepare for database views avram#552 it's no longer by default supported to reference parameterized actions as Action::Name.with(model_object) -- instead try Action::Name.with(model_object.id)

[robacarp]

Update for ResetPasswordRequest, SignInUser is similar:

  # Run validations and yield the operation and the user if valid
-  def submit
+  def run
    user = user_from_email
    validate(user)

    if valid?
-      yield self, user
+      user
    else
-      yield self, nil
+      nil
    end
  end

[robacarp]

Update for PasswordResetRequests::Create, SignIns::Create is similar:

  route do
-    RequestPasswordReset.new(params).submit do |operation, user|
+    RequestPasswordReset.run(params) do |operation, user|
      if user

[robacarp]

[jwoertink]

This probably isn't necessary now since we added this back in luckyframework/avram#559

[robacarp]

fantastic! I didn't see that go in.

[robacarp]

Generated code update for log "Executing Query" annoyance:

Update config/log.cr:

  # Use a pretty formatter printing to STDOUT in development
  backend = Log::IOBackend.new
  backend.formatter = Lucky::PrettyLogFormatter.proc
  Log.dexter.configure(:debug, backend)
+  DB::Log.level = :info
end

[stephendolan]

I've updated LuckyDiff as well:

https://luckydiff.com/?from=0.24.0&to=0.25.0

[jwoertink]

Thanks for putting this together @robacarp! It's all now ready for the UPGRADE_NOTES https://github.com/luckyframework/lucky/pull/1365/files Let me know if you find anything missing on there. That will be merged in maybe tomorrow.

[robacarp]

looks great, thanks!