Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duration pitch loss not used. #34

Open
jaykim9870 opened this issue Feb 6, 2024 · 2 comments
Open

Duration pitch loss not used. #34

jaykim9870 opened this issue Feb 6, 2024 · 2 comments

Comments

@jaykim9870
Copy link

Hello, I was looking into your code and it seems like the code does not consider the duration_pitch_loss.

Maybe, it might be related to the aux_loss you have made.

aux_loss = (duration_loss * self.duration_loss_weight) \

Thanks for the great work!

@wonwooo
Copy link

wonwooo commented Feb 19, 2024

@jaykim9870
I have the same question.
You're thinking that code should be changed like below. Right?

before : return loss + (self.rvq_cross_entropy_loss_weight * ce_loss) + duration_pitch_loss

fixed : return loss + (self.rvq_cross_entropy_loss_weight * ce_loss) + aux_loss

@jaykim9870
Copy link
Author

@wonwooo
Yes, that would do.

FYI, There are some other issues like wavenet based diffusion model as the model size is very different from the original paper. As far as I have investigated, the model architecture is too different so it may affect the model performance. If you are working based on this project, you may also need to check those out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants