Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve annotation deletion #9

Open
2 tasks
luccalb opened this issue Sep 7, 2023 · 0 comments
Open
2 tasks

Improve annotation deletion #9

luccalb opened this issue Sep 7, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@luccalb
Copy link
Owner

luccalb commented Sep 7, 2023

When the textof an annotation is deleted, the annotation visually disappears but is still stored in the annotation map with to === from, which is an invalid annotation state.

  • either completely delete the annotation from storage on document remapping
  • orprovide a callback function like onAnnotationDelete():boolean to be called when changing the document would result in the removl of an annotation, the user could then provide a function to decide if the document change should pass or not (e.g. a modal)
@luccalb luccalb added the bug Something isn't working label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant