Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the file ts8/rafts.yaml has arbitrary (and incorrect) detector numbers #561

Open
aaronroodman opened this issue Oct 9, 2024 · 5 comments

Comments

@aaronroodman
Copy link

Posting this in case the policy/ts8/rafts.yaml file is used or needed in the future. Looking at some TS8 single raft test images uncovered that the detector values in the rafts.yaml file are arbitrary, and do not correspond to the actual detector numbers of the rafts as placed in LSSTCam.

The attached file has the as-built detector numbers for all rafts, and assigns id0=18 for the two rafts not in the LSSTCam focal plane, RTM-031 in ComCam and RTM-004 the spare raft currently in the SLAC TS8.

rafts.yaml.txt

@timj
Copy link
Member

timj commented Oct 9, 2024

The original TS8 file was made long ago before anything was assembled. I'm happy to change it but @jchiang87 should comment because it would mean that you likely need to rebuild any TS8 repos or at least understand that a new repo should be constructed with the new detector because trying to add some TS8 data to an existing repo is going to be extremely confusing.

@aaronroodman
Copy link
Author

Yes, understand that. @jchiang87 and I were looking into this. The only TS8 data in a repo is quite new and uses only the spare raft, RTM-004, whose value I kept the same. Right now I don't see a need to add any of the old TS8 data to a repo, but if I did we would need this file updated.

@jchiang87
Copy link
Contributor

jchiang87 commented Oct 9, 2024

I had a quick look at /repo/main and there do appear to be TS8 data there as well. I didn't follow up on specific RTMs though, but I can post a list here later today.

@jchiang87
Copy link
Contributor

The TS8 data in /repo/main are just copies of some of the runs in /repo/ir2.

@timj
Copy link
Member

timj commented Oct 9, 2024

If you want this change to happen please make a Jira ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants