Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47254: Persist subtractImages kernelSources #348

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

isullivan
Copy link
Contributor

No description provided.

Copy link
Contributor

@BrunoSanchez BrunoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no big issues here.
Question: Do we need any sort of unit test in here?

@@ -247,7 +259,7 @@ def setDefaults(self):
self.makeKernel.kernel.active.spatialKernelOrder = 1
self.makeKernel.kernel.active.spatialBgOrder = 2
self.sourceSelector.doFlags = True
self.sourceSelector.flags.good = ["calib_psf_used",]
self.sourceSelector.flags.good = ["calib_psf_used", ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it fixes a linting warning, and is a separate commit

@isullivan isullivan merged commit 1008875 into main Oct 29, 2024
2 checks passed
@isullivan isullivan deleted the tickets/DM-47254 branch October 29, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants