cicd/tcpsctpperf: Hosts ep2,3 are started but not used

[luisgerhorst]

loxilb/cicd/tcpsctpperf/config.sh

Line 31 in 73f7935

config_docker_host --host1 l3ep2 --host2 llb1 --ptype phy --addr 32.32.32.1/24 --gw 32.32.32.254

I believe these are not actually used. Should they be removed or does it make sense to adapt the benchmark to actually use them?

[TrekkieCoder]

Your observation is correct. These are not needed and it would be best to remove them as these might consume resources which can in some.way adversely impact the perf test itself.

[TrekkieCoder]

Closing this as per this commit

[luisgerhorst]

I'm sorry I think there was some confusion. The MR was not ready for merging and thus did not fix this issue, it was only a request for comments regarding the benchmarking approach. Please reopen, I will close it myself when appropriate. (I'm sorry if this was not clear, I will make it more explicit next time.)

[TrekkieCoder]

Ok got it. Noticed a few breaks in loxilb's cicd. I will temporarily fix this. Please double check and commit once all your changes are ready.

[luisgerhorst]

Yes, this is expected. I will create a PR with a hotfix, you either apply that or revert the whole series.

[luisgerhorst]

With #460 this should be fixed. But to repeat: #460 was not tested. I appreciate the fast merge but I intended to look at the CI output first :D - We will see I guess.

[TrekkieCoder]

The hotfix worked. Will be looking forward for your full set of perf script changes. Looks great !!