Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't find “water.” #12

Closed
abcdvvvv opened this issue Nov 22, 2024 · 4 comments
Closed

Can't find “water.” #12

abcdvvvv opened this issue Nov 22, 2024 · 4 comments

Comments

@abcdvvvv
Copy link

Hello. I'm new to this pack. I tried to search for water as shown in the tutorial, but the return value is missing.

using ChemicalIdentifiers
res = search_chemical("water") # return missing
res = search_chemical((7732, 18, 5)) # return missing

May I ask what is going on?

@longemen3000
Copy link
Owner

longemen3000 commented Nov 22, 2024

hello,

Thanks for letting me know of this issue. I can reproduce it in my computer. what probably is happening is that the database file (from calebbell/chemicals) was updated, so probably i need to update some code here too

@longemen3000
Copy link
Owner

longemen3000 commented Nov 22, 2024

found the issue, water is now in a new database (https://github.com/CalebBell/chemicals/blob/master/chemicals/Identifiers/Inorganic%20db.tsv), it was moved last week.
You add that database yourself, or wait for a new version of this package to be released (in a few hours)

@abcdvvvv
Copy link
Author

I see. Thank you for your reply! I will wait for the new version to be released.

@longemen3000
Copy link
Owner

The new version is already released, try it out, and if it solves your problem, feel free to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants