Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usages of deprecated LocalStack code features in AWS replicator #45

Open
alexrashed opened this issue Nov 28, 2023 · 0 comments · May be fixed by #62
Open

Remove usages of deprecated LocalStack code features in AWS replicator #45

alexrashed opened this issue Nov 28, 2023 · 0 comments · May be fixed by #62

Comments

@alexrashed
Copy link
Member

alexrashed commented Nov 28, 2023 •
edited
Loading

Currently, the AWS Replicator extension is using some parts of the LocalStack codebase which is deprecated and about to be removed:

  • localstack.utils.server.http2_server.run_server which is based on Quart (which has been superseded by the underlying hypercorn quite some time ago).
  • localstack.aws.api.HttpRequest which should be replaced with localstack.http.Request.

These usages are currently blocking the following PRs in localstack/localstack:

It would be best to refactor the AWS Replicator Extension such that it spawns the Auth Proxy a new Gateway (and migrate the logic to a implement a LocalStack handlerchain handler).
/cc @lukqw @whummer @thrau
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove use of http2_server in replicator aws proxy localstack/localstack-extensions
1 participant
@alexrashed