Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It might be better to rewrite the existing tests. #26

Open
lobophf opened this issue Sep 26, 2020 · 2 comments
Open

It might be better to rewrite the existing tests. #26

lobophf opened this issue Sep 26, 2020 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@lobophf
Copy link
Owner

lobophf commented Sep 26, 2020

Existing tests can be improved because I feel that there are many similar codes.. Perhaps the environment can be rewritten considering the test fixtures. Each test of the sub2ind and ind2sub functions could share the same information to decrease the code lines.

@lobophf lobophf added the help wanted Extra attention is needed label Sep 26, 2020
@goodengineer
Copy link

goodengineer commented Feb 28, 2023

impr.h.zip

@lobophf
Copy link
Owner Author

lobophf commented Mar 11, 2023

Hello @goodengineer.
Thanks for your contribution. Just to know, why did you zip it instead of making a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants