-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check what RSE Sheffield have been up to and cut ties #246
Comments
we are ready to cut ties - the only thing we don't have that they do is renv and because participants fork and clone and interact with this but haven't learned renv I'd rather avoid it. I've now printed the session and indicated which combination of packages work (both latest of ggplot and ploty together or both older version together work) |
original repo also linked in read me - we are ready to cut ties |
How would you feel about including a call to E.g. the .R or .Rmd scripts in this tutorial would have code like this at the beginning of the script:
I think this would allow us to make sure participants are using the desired version of packages (so that nothing breaks) without having to include a full renv lockfile in this repo (and thus avoid confusing participants). |
that seems very nice! let me describe the situation so you can tell me yourself whether this is the perfect solution: participants fork and clone my repo, they only create a copy of a R scrip to add parameters - there is no pacakges loaded there. then they push that and create a pull request. then they see ME run the RDM file with everyone's parameters. then they pull upstream to get everyone elses parameters. the tutorial stops here. but in principle some coupld then try and run my RDM file. my requierement: I don't want them to have any different exeprience with their steps that are part of the tutorial. We can definitively add isntructions on how to run the RMD that only participants who want to do this extra can try it out. Would this solution you suggest work? it seems like it - we would need to install and require renv to run the RMD right? |
Ah, if the tutorial participants are only using/editing/running an R script that uses base R functions, then I don't think it would be necessary to include the I could, however, add |
yes, we can do that for the rmd file, but again, for me I just dont want participants to have any error or pop up window when they fork and clone the repository and then push and pull upstream, e.g. telling them they need to download renv before being able to do anything. if this doesn't happen - we can add that. |
Ok I made a draft of this, but I'll break the fork connection |
thanks for looking into it! I'm happy to revisit when you come accross better ways! |
Ticket with GitHub opened. (I'm not sure this ticket will be visible to anyone but me though https://support.github.com/ticket/personal/0/2820372) |
No description provided.
The text was updated successfully, but these errors were encountered: